Noticed 'get_game_server_steamid' is being defined twice

[BackRaw]

Hi,

I just looked at the code in ../src/core/modules/engines/engines_wrap_python.cpp: https://github.com/Source-Python-Dev-Team/Source.Python/blob/master/src/core/modules/engines/engines_wrap_python.cpp#L685

Syntax: Select all

.def("get_game_server_steamid",
    &IVEngineServer::GetGameServerSteamID,
    "Returns the SteamID of the game server.",
    reference_existing_object_policy()
)
.def("get_game_server_steamid",
    &IVEngineServer::GetGameServerSteamID,
    "Returns the SteamID of the game server.",
    reference_existing_object_policy()
)

I don't know if this was intended or if this was a mistake :)

[satoon101]

Thanks for reporting. While posting here is perfectly fine, we would like people to start posting these on the Issues List. Also, it would be helpful to make this change yourself and submit a pull request.

[BackRaw]

Thanks for reporting. While posting here is perfectly fine, we would like people to start posting these on the Issues List. Also, it would be helpful to make this change yourself and submit a pull request.

Okay. Well I don't want to mess anything up so I'll post them on the Issues List next time.

[satoon101]

Not sure what you mean by "mess anything up". Do you mean by doing a pull request? You cannot really mess anything up with those, as we still have to accept the changes and pull them into the repo ourselves. We have already had 3 people issue pull requests previously which have been added in.
https://github.com/Source-Python-Dev-Team/Source.Python/pulls?q=is%3Apr+is%3Aclosed


In this particular one, we had a long discussion about the implementation before the changes were merged into the master branch:
https://github.com/Source-Python-Dev-Team/Source.Python/pull/1



*Edit: sorry, I should have posted sooner, but I already fixed what you posted:
https://github.com/Source-Python-Dev-Team/Source.Python/commit/6cc0b87152c0b267ad044fa1388979142bca7e4b

**Edit2: if you need help with Pull Requests, you should check out GitHub's documentation on it:
https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&cad=rja&uact=8&ved=0CB4QFjAA&url=https%3A%2F%2Fhelp.github.com%2Farticles%2Fusing-pull-requests&ei=reUNVJnwC8uiyATKsoDIAg&usg=AFQjCNHg51rjVb2Qs3CsfBXKeTt3p1yTSg&sig2=pB8_LIiERghtQV9e1zhk8A&bvm=bv.74649129,d.aWw

[BackRaw]

Didn't know about that. I'll look into it when I get time.